Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Table: Allow adding a column id separate from the column title #79

Closed
diondiondion opened this issue Apr 27, 2020 · 0 comments
Closed
Labels
enhancement New feature or request

Comments

@diondiondion
Copy link
Member

diondiondion commented Apr 27, 2020

Problem

Currently, the Table component's sort handler returns the name of the column that the sorting was changed on. Since the name of a column currently doubles as its readable title, this name may be a dynamic, localised string, which is inconvenient for the purpose of serving as an identifier when changing column sorting.

Proposed solution

  • Rename current name prop to title, make it isRequired
  • Make the name prop optional and use it as a static identifier that is not exposed in the UI
@diondiondion diondiondion added the enhancement New feature or request label Apr 27, 2020
diondiondion added a commit that referenced this issue Apr 30, 2020
BREAKING CHANGE:
The old name prop on Column instances was changed
to title and needs to be updated accordingly.
5app-Machine added a commit that referenced this issue Apr 30, 2020
# [9.0.0](v8.3.0...v9.0.0) (2020-04-30)

### Features

* **Table:** Add new prop `title` to Column, [#79](#79) ([7fe11b4](7fe11b4))

### BREAKING CHANGES

* **Table:** The old name prop on Column instances was changed
to title and needs to be updated accordingly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant