fix: apply Dion type suggestions #182

Co-authored-by: diondiondion <[email protected]>
5app · Mar 25, 2022 · c6aabed · c6aabed
1 parent 15db782
commit c6aabed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Icon/index.tsx b/src/Icon/index.tsx
@@ -24,8 +24,8 @@ interface CustomIconProps {
 	name: string,
 	scale: number,
 	size: string,
-	spacingLeft: any, // seems this can take a string or a number, not good!
-	spacingRight: any,
+	spacingLeft: string | number,
+	spacingRight: string | number,
 	theme: LocalThemeSection
 }
 

diff --git a/src/icons/BaseSvg.ts b/src/icons/BaseSvg.ts
@@ -32,10 +32,11 @@ interface StyledIconBase {
 	spacingLeft?: string,
 	spacingRight?: string,
 	scale?: number,
-	vAlign?: string, // not sure about this one
+	vAlign?: boolean,
 	dimmed?: boolean,
 	disablePointerEvents?: boolean,
-	flip?: number // also not sure about this one
+	flip?: 'x' | 'y',
+	rotate?: number,
 }
 
 const Svg = styled.svg.withConfig({shouldForwardProp})<StyledIconBase>`