Updating the Service Access Information - Support for the expires header #51 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In case both max-age and expires are present the values shall be translated to absolute times, compared and the earlier value shall be used. 2. In case none of the headers are defined, we use a static configurable refresh value like 10 minutes.
1. support Age 2. remove log 3. add comment
dsilhavy
requested changes
Feb 1, 2024
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
Outdated
Show resolved
Hide resolved
1. Only import the classes that need instead of the whole package
2. Refine and remove warnings
3. Reformat the code: The { in the same line
4. Rename variants
added 2 commits
February 29, 2024 11:59
Refactor code: extract functions
…d value be configured in configuration file
|
Pushed code for 4 repos including
|
…ation file to Media Session Handler
dsilhavy
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51