Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a menu to show license and about information #39

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

dsilhavy
Copy link
Contributor

@dsilhavy dsilhavy commented Sep 5, 2023

This PR adds a menu selection on the top right with the items "License" and "About". See screenshots below for more details:

Menu

Bildschirmfoto 2023-09-05 um 13 26 01

Menu Selection

Bildschirmfoto 2023-09-05 um 13 26 09

License

Bildschirmfoto 2023-09-05 um 13 25 51

About

Bildschirmfoto 2023-09-05 um 13 26 55

@dsilhavy dsilhavy added this to the Version 1.0.3 milestone Sep 5, 2023
@dsilhavy
Copy link
Contributor Author

dsilhavy commented Sep 5, 2023

@jordijoangimenez Do we need anything else here also considering a potential submission to the Play Store? Attribution Notice?

@jordijoangimenez
Copy link
Contributor

You are fast, Daniel.
I'd include the attribution notice. And I'd also include the "copyrighters"/authors... I mean anything that is not visible that is in the code may find a place here.

Something like this (at the end)
Screenshot_2023-09-05-13-50-04-44

@dsilhavy
Copy link
Contributor Author

dsilhavy commented Sep 6, 2023

Added more details in the about section and an auto-generated list of dependencies, see below:

About

Bildschirmfoto 2023-09-06 um 10 48 19

Menu

Bildschirmfoto 2023-09-06 um 10 48 30

Attribution Notice

Bildschirmfoto 2023-09-06 um 10 48 37

@jordijoangimenez
Copy link
Contributor

Wow! 👏

@dsilhavy
Copy link
Contributor Author

dsilhavy commented Sep 8, 2023

Updated "about" view. Also added scrollable view in case all the information does not fit into the window.

Part 1

Bildschirmfoto 2023-09-08 um 10 28 47

Part 2

Bildschirmfoto 2023-09-08 um 10 28 53

@dsilhavy dsilhavy merged commit a9630cd into development Sep 12, 2023
@dsilhavy dsilhavy modified the milestones: Version 1.0.3, Version 1.1.0 Sep 26, 2023
@dsilhavy dsilhavy deleted the feature/menu branch September 28, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants