Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

MGDOBR-296: improve dev scripts for local development #314

Merged
merged 13 commits into from
Feb 10, 2022

Conversation

kostola
Copy link
Contributor

@kostola kostola commented Feb 9, 2022

MGDOBR-296

Please make sure that your PR meets the following requirements:

  • Your code is properly formatted according to this configuration
  • Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
  • All new functionality is tested
  • Pull Request title is properly formatted: MGDOBR-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Annotate your PR with the label safe to test in order to run the end to end CI pipeline

@kostola kostola requested a review from lucamolteni February 9, 2022 16:33
@kostola kostola marked this pull request as ready for review February 10, 2022 10:43
@kostola kostola requested a review from robpblake February 10, 2022 10:44
Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kostola . +1 from me, pending a run-through on Mac from @lucamolteni

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kostola
Copy link
Contributor Author

kostola commented Feb 10, 2022

I spoke with @lucamolteni and he's a bit busy at the moment, so we decided to merge this and open a fix PR for Mac if needed, so @sutaakar can move on with #312

@kostola kostola merged commit 3ea2249 into 5733d9e2be6485d52ffa08870cabdee0:main Feb 10, 2022
@kostola kostola deleted the MGDOBR-296 branch February 17, 2022 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants