Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black horizontal line on top of pulley on Mac Catalyst #430

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mpfeifer-svg
Copy link
Contributor

@mpfeifer-svg mpfeifer-svg commented Dec 3, 2024

The height and position of the pulley is rounded to nearest even number on Mac Catalyst. This will fix the horizontal ghost line.

Description

The line may disappear if the window is resized. We have the same issue on the toolbar in the view behind the pulley. Now it behaves like removing the pulley from the view.

Fixes #424 Strange lines on mac catalyst 16

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested the change using our app on the following devices. The change is effective for target platform mac catalyst only.

  • Test Mac OS 15.1.1 (Mac Catalyst)
  • Test iOS 18
  • Test iOS 17

Test Configuration

  • Xcode Versions: 16.1
  • Simulators: -
  • Physical Hardware: Mac Book Pro (M1), iPad Pro 10.5" (iOS 17.7.2), iPhone 12 Pro (iOS 18.1.1)

Checklist:

  • My code follows the style guidelines of this project
  • My code does not break backwards compatibility with earlier versions of PulleyLib
  • My code is fully functional with all supported device sizes and orientations
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked that my code does not break the behavior of the Sample/Demo app
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested and can prove my fix is effective or that my feature works

The height and position of the pulley is rounded to nearest even number on Mac Catalyst. This will fix the horizontal ghost line.
@ulmentflam ulmentflam merged commit 9d58b99 into 52inc:master Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange lines on mac catalyst 16
2 participants