Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve contribution docs #212

Merged
merged 5 commits into from
Oct 19, 2023
Merged

improve contribution docs #212

merged 5 commits into from
Oct 19, 2023

Conversation

ohadschn
Copy link
Collaborator

Also-

  1. Add wdm gem for local windows development (avoid poll)
  2. Remove redundant contributors list (info already available on GitHub)

docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
Info is already availalbe on GitHub
removed redundant instructions (standard across all github projects)
per PR comments
@ohadschn ohadschn force-pushed the feature/improve-contribution-docs branch from 39183b4 to b444e14 Compare October 18, 2023 20:42
@4tal
Copy link
Collaborator

4tal commented Oct 19, 2023

Why do we need the Github API Token?

@4tal 4tal merged commit 7538411 into main Oct 19, 2023
@ohadschn
Copy link
Collaborator Author

@4tal see the link in that section, it gets rid of a warning (everything appears to work without it, I just don't like warnings for too many reasons to list here)

@4tal 4tal deleted the feature/improve-contribution-docs branch November 19, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants