Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed public modifier for methods on interfaces because it is redundant #547

Merged
merged 2 commits into from
May 18, 2017
Merged

Removed public modifier for methods on interfaces because it is redundant #547

merged 2 commits into from
May 18, 2017

Conversation

Gaboso
Copy link
Contributor

@Gaboso Gaboso commented May 18, 2017

Removed public modifier for methods on interfaces because it is redundant.

Copy link
Collaborator

@metaprime metaprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about the public quantifier, but thanks for the contribution!

Just a nitpick before I merge, can you remove the extra blank lines you introduced?


void rip() throws IOException;

boolean canRip(URL url);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no benefit to all the blank lines here. I think it's more readable in compressed form.

@metaprime metaprime merged commit c4ee756 into 4pr0n:master May 18, 2017
metaprime added a commit that referenced this pull request May 18, 2017
Removed public modifier for methods on interfaces because it is redundant
@metaprime metaprime self-assigned this May 18, 2017
@Gaboso Gaboso deleted the interfaces branch May 18, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants