Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BufferOverflowException when import data fix #3728 #3729

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

ljwh
Copy link
Contributor

@ljwh ljwh commented Jan 26, 2024

close #3728

@dl239
Copy link
Collaborator

dl239 commented Jan 29, 2024

@dl239
Copy link
Collaborator

dl239 commented Jan 30, 2024

it's better to add the test case in https://github.com/4paradigm/OpenMLDB/blob/main/java/openmldb-common/src/test/java/com/_4paradigm/openmldb/common/RowCodecTest.java

done

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2f85fb) 40.18% compared to head (0b66af0) 78.20%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3729       +/-   ##
=============================================
+ Coverage     40.18%   78.20%   +38.02%     
=============================================
  Files           193      539      +346     
  Lines         11384   120229   +108845     
  Branches       1366        0     -1366     
=============================================
+ Hits           4575    94029    +89454     
- Misses         6510    26200    +19690     
+ Partials        299        0      -299     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 1a714ee into 4paradigm:main Feb 22, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import data cause BufferOverflowException
3 participants