Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deployment): create index for more sqls #3667

Merged
merged 1 commit into from
Dec 20, 2023
Merged

feat(deployment): create index for more sqls #3667

merged 1 commit into from
Dec 20, 2023

Conversation

aceforeverd
Copy link
Collaborator

fix #3614

@github-actions github-actions bot added batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Dec 7, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (e7538bd) 74.94% compared to head (c211823) 74.97%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/base/ddl_parser.cc 76.78% 13 Missing ⚠️
hybridse/src/vm/sql_compiler.h 64.70% 6 Missing ⚠️
...se/src/passes/physical/group_and_sort_optimized.cc 96.55% 2 Missing ⚠️
src/sdk/sql_cluster_router.cc 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3667      +/-   ##
============================================
+ Coverage     74.94%   74.97%   +0.02%     
  Complexity      642      642              
============================================
  Files           725      725              
  Lines        130823   130744      -79     
  Branches       1326     1323       -3     
============================================
- Hits          98051    98020      -31     
+ Misses        32479    32431      -48     
  Partials        293      293

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd force-pushed the feat-auto-depoyment-index branch from ae9e9e9 to b0d984f Compare December 7, 2023 09:08
@aceforeverd aceforeverd force-pushed the feat-auto-depoyment-index branch from b0d984f to 0ce6e39 Compare December 8, 2023 02:38
@github-actions github-actions bot removed the batch-engine openmldb batch(offline) engine label Dec 8, 2023
@aceforeverd aceforeverd force-pushed the feat-auto-depoyment-index branch from 0ce6e39 to dda067a Compare December 11, 2023 10:08
@github-actions github-actions bot added the build openmldb compiling and installing label Dec 11, 2023
@aceforeverd aceforeverd force-pushed the feat-auto-depoyment-index branch from dda067a to 689188f Compare December 12, 2023 06:09
@aceforeverd aceforeverd force-pushed the feat-auto-depoyment-index branch from 689188f to c211823 Compare December 12, 2023 07:19
@aceforeverd aceforeverd merged commit 1448df8 into 4paradigm:main Dec 20, 2023
@aceforeverd aceforeverd deleted the feat-auto-depoyment-index branch December 20, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@lqy222 lqy222 lqy222 approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

@dl239 dl239 Awaiting requested review from dl239

Assignees
No one assigned
Labels
build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(ddl_parser): support create index for new SQLs
3 participants
@aceforeverd @vagetablechicken @lqy222