Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create function return success if create failed on tablet #3441

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Aug 16, 2023

close #3440

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f6dc23e) 75.79% compared to head (e3a1734) 75.79%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3441   +/-   ##
=========================================
  Coverage     75.79%   75.79%           
  Complexity      414      414           
=========================================
  Files           703      703           
  Lines        127658   127661    +3     
  Branches       1206     1206           
=========================================
+ Hits          96759    96763    +4     
+ Misses        30658    30657    -1     
  Partials        241      241           
Files Changed Coverage Δ
src/cmd/single_tablet_test.cc 99.31% <100.00%> (+0.01%) ⬆️
src/nameserver/name_server_impl.cc 44.92% <100.00%> (+0.02%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 enabled auto-merge (squash) August 21, 2023 03:22
@dl239 dl239 merged commit a6d7322 into 4paradigm:main Aug 21, 2023
23 checks passed
dl239 added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create function return success if dynamic library load failed
3 participants