Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support drop database/table if exists #3348

Merged
merged 12 commits into from
Jul 14, 2023
Merged

feat: support drop database/table if exists #3348

merged 12 commits into from
Jul 14, 2023

Conversation

emo-coder
Copy link
Contributor

@emo-coder emo-coder commented Jul 7, 2023 •
edited by dl239
Loading

close #3132 #2022

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 84.21% and project coverage change: -0.03 ⚠️

Comparison is base (83937c5) 75.67% compared to head (09797a9) 75.65%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3348      +/-   ##
============================================
- Coverage     75.67%   75.65%   -0.03%     
  Complexity      414      414              
============================================
  Files           692      692              
  Lines        125963   126003      +40     
  Branches       1189     1190       +1     
============================================
+ Hits          95317    95322       +5     
- Misses        30405    30440      +35     
  Partials        241      241
Impacted Files Coverage Δ
src/client/ns_client.h 100.00% <ø> (ø)
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/client/ns_client.cc 53.11% <66.66%> (-0.01%) ⬇️
src/sdk/sql_cluster_router.cc 61.01% <85.71%> (-0.25%) ⬇️
hybridse/src/planv2/ast_node_converter.cc 94.36% <100.00%> (+<0.01%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dl239 dl239 changed the title Feat/drop if exists feat: support drop database/table if exists Jul 11, 2023
@dl239 dl239 marked this pull request as ready for review July 11, 2023 02:26
dl239
dl239 reviewed Jul 11, 2023
View reviewed changes
src/client/ns_client.cc Outdated Show resolved Hide resolved
dl239
dl239 reviewed Jul 11, 2023
View reviewed changes
cases/plan/cmd.yaml Outdated Show resolved Hide resolved
@aceforeverd aceforeverd linked an issue Jul 12, 2023 that may be closed by this pull request
support drop table if exists #2022
Closed
@vagetablechicken vagetablechicken merged commit 291ec6a into 4paradigm:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dl239 dl239 dl239 approved these changes

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@aceforeverd aceforeverd aceforeverd approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

@lqy222 lqy222 Awaiting requested review from lqy222

Assignees
No one assigned
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SQL syntax of "DROP TABLE IF EXISTS" support drop table if exists
5 participants
@emo-coder @dl239 @aceforeverd @vagetablechicken @zhangziheng01233