Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy with data #3288

Merged
merged 28 commits into from
Jun 7, 2023
Merged

feat: deploy with data #3288

merged 28 commits into from
Jun 7, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented May 21, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 21, 2023
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 71.26% and project coverage change: -3.30 ⚠️

Comparison is base (0d94caf) 78.98% compared to head (1f6ca99) 75.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3288      +/-   ##
============================================
- Coverage     78.98%   75.69%   -3.30%     
- Complexity        0      393     +393     
============================================
  Files           513      689     +176     
  Lines        115709   125295    +9586     
  Branches          0     1186    +1186     
============================================
+ Hits          91391    94839    +3448     
- Misses        24318    30219    +5901     
- Partials          0      237     +237     
Impacted Files Coverage Δ
src/client/ns_client.h 100.00% <ø> (ø)
src/nameserver/name_server_impl.cc 44.86% <ø> (+0.43%) ⬆️
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/tablet/tablet_impl.h 100.00% <ø> (ø)
src/tablet/tablet_impl_test.cc 99.53% <ø> (-0.02%) ⬇️
src/client/tablet_client.cc 57.74% <53.33%> (-1.14%) ⬇️
src/codec/row_codec.cc 55.41% <55.41%> (ø)
src/storage/mem_table_snapshot.cc 69.62% <67.13%> (+6.15%) ⬆️
src/sdk/sql_cluster_router.cc 62.52% <72.36%> (-0.27%) ⬇️
src/client/ns_client.cc 51.90% <73.33%> (+0.35%) ⬆️
... and 13 more

... and 193 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dl239 dl239 changed the title feat: deploy with data 1 feat: deploy with data Jun 2, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 5, 2023
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 10721cd into 4paradigm:main Jun 7, 2023
dl239 added a commit that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants