Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add the chinese version of application architecture #3189

Merged
merged 6 commits into from
Apr 18, 2023
Merged

docs: add the chinese version of application architecture #3189

merged 6 commits into from
Apr 18, 2023

Conversation

TanZiYen
Copy link
Contributor

@TanZiYen TanZiYen commented Apr 4, 2023

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 4, 2023
lumianph
lumianph requested changes Apr 10, 2023
View reviewed changes
docs/zh/tutorial/common architecture.md Outdated

## 全量数据存储于实时数据库（不推荐）

![实时决策1](C:\Users\User\Downloads\OpenMLDB\docs\zh\tutorial\images\实时决策1.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. use the english filename
  2. change it to relative path, e.g. "images/figure1.png"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apply those two changes to all figures accordingly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, there should be no space in the file name "common architecture.md" => "common_architecture.md"

@lumianph lumianph changed the title docs_tutorial_zh_common architecture docs: add the chinese version of application architecture Apr 10, 2023
lumianph
lumianph reviewed Apr 18, 2023
View reviewed changes
docs/zh/tutorial/common_architecture.md Outdated

## 全量数据存储于实时数据库（不推荐）

![ca1](C:\Users\65972\Documents\GitHub\OpenMLDB\docs\zh\tutorial\images\ca1.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change all paths to like this: images/ca1.png,

@lumianph lumianph merged commit 789cacc into 4paradigm:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumianph lumianph lumianph approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanZiYen @lumianph