Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checking if there is data in the base table for long window deploy #2501

Merged
merged 8 commits into from
Sep 20, 2022

Conversation

zhanghaohit
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix #2483

  • add checking if there is data in the base table for long window deployment
  • add checking in LogReader for offset
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

…loyment

- add checking in LogReader for `offset`
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 75.78% // Head: 75.80% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d89d315) compared to base (9506905).
Patch coverage: 87.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2501      +/-   ##
============================================
+ Coverage     75.78%   75.80%   +0.01%     
  Complexity      371      371              
============================================
  Files           638      638              
  Lines        120380   120453      +73     
  Branches       1051     1051              
============================================
+ Hits          91235    91309      +74     
+ Misses        28928    28927       -1     
  Partials        217      217              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 57.38% <45.00%> (+0.09%) ⬆️
src/base/ddl_parser.cc 74.78% <50.00%> (ø)
src/storage/aggregator.cc 77.80% <70.00%> (-1.01%) ⬇️
src/replica/log_replicator_test.cc 94.21% <97.91%> (+0.37%) ⬆️
src/cmd/sql_cmd_test.cc 99.00% <100.00%> (+<0.01%) ⬆️
src/log/log_reader.cc 79.77% <100.00%> (+3.30%) ⬆️
src/log/log_reader.h 100.00% <100.00%> (ø)
src/tablet/tablet_impl_test.cc 99.54% <100.00%> (+<0.01%) ⬆️
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

Linux Test Report

       55 files       203 suites   1h 6m 50s ⏱️
  9 907 tests   9 900 ✔️ 7 💤 0
14 583 runs  14 576 ✔️ 7 💤 0

Results for commit d89d315.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

SDK Test Report

  81 files    81 suites   7m 4s ⏱️
168 tests 166 ✔️ 2 💤 0
210 runs  208 ✔️ 2 💤 0

Results for commit d89d315.

♻️ This comment has been updated with latest results.

@zhanghaohit zhanghaohit requested a review from dl239 September 19, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tablet keeps CPU 160%
4 participants