-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): limt clause conjunction with where clause or group by clause #2447
Conversation
Codecov ReportBase: 75.90% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2447 +/- ##
============================================
- Coverage 75.90% 75.79% -0.12%
Complexity 368 368
============================================
Files 629 638 +9
Lines 119694 119939 +245
Branches 1044 1056 +12
============================================
+ Hits 90859 90907 +48
- Misses 28619 28816 +197
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the pr also correct behavior of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes:
limit 0
: should returns empty listclose #2433
the pr introduce a new iterator (
LimitIterator
) used for limit clause conjunction with where clause. The iterator is not seekable, so window project over this is not supported as well, we need the compile time check for this.some restrictions should noted: