Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create failed if partitionnum not equal distribution list size #2434

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Sep 5, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Base: 75.90% // Head: 75.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (237f506) compared to base (6175266).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2434      +/-   ##
============================================
+ Coverage     75.90%   75.92%   +0.01%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119694   119705      +11     
  Branches       1044     1044              
============================================
+ Hits          90859    90881      +22     
+ Misses        28619    28608      -11     
  Partials        216      216              
Impacted Files Coverage Δ
src/sdk/node_adapter.cc 48.10% <33.33%> (-0.36%) ⬇️
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
src/sdk/db_sdk.cc 66.14% <0.00%> (-2.70%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/tablet/tablet_impl.cc 61.60% <0.00%> (-0.03%) ⬇️
src/client/tablet_client.cc 56.04% <0.00%> (ø)
hybridse/src/vm/runner.cc 68.14% <0.00%> (+0.03%) ⬆️
src/nameserver/name_server_impl.cc 42.79% <0.00%> (+0.04%) ⬆️
hybridse/src/codec/type_codec.cc 76.71% <0.00%> (+1.82%) ⬆️
src/log/log_reader.cc 79.11% <0.00%> (+2.64%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

SDK Test Report

  79 files    79 suites   6m 57s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 237f506.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Linux Test Report

       55 files       200 suites   1h 4m 1s ⏱️
  9 753 tests   9 746 ✔️ 7 💤 0
14 354 runs  14 347 ✔️ 7 💤 0

Results for commit 237f506.

@dl239 dl239 linked an issue Sep 6, 2022 that may be closed by this pull request
@dl239 dl239 enabled auto-merge (squash) September 6, 2022 03:11
Copy link
Contributor

@wuyou10206 wuyou10206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@dl239 dl239 merged commit 06367b0 into 4paradigm:main Sep 6, 2022
@dl239 dl239 deleted the fix/distribution branch November 16, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show table status display error
3 participants