Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed duplicated compile_proto #2392

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

zahyaah
Copy link
Contributor

@zahyaah zahyaah commented Aug 23, 2022

Removed duplicated compile_proto from src/CMakeLists.txt

image

Deleted line number 91

@github-actions github-actions bot added build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet labels Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #2392 (2fdd3d8) into main (b213dc8) will decrease coverage by 3.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2392      +/-   ##
============================================
- Coverage     79.02%   75.90%   -3.12%     
- Complexity        0      368     +368     
============================================
  Files           484      629     +145     
  Lines        110939   119721    +8782     
  Branches          0     1044    +1044     
============================================
+ Hits          87667    90874    +3207     
- Misses        23272    28631    +5359     
- Partials          0      216     +216     
Impacted Files Coverage Δ
hybridse/src/codec/fe_row_codec.cc 78.36% <0.00%> (-0.32%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (-0.07%) ⬇️
src/tablet/tablet_impl.cc 61.60% <0.00%> (-0.03%) ⬇️
src/client/tablet_client.cc 56.04% <0.00%> (ø)
...n/java/com/_4paradigm/openmldb/jdbc/Statement.java 27.90% <0.00%> (ø)
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 77.14% <0.00%> (ø)
...om/_4paradigm/openmldb/batch/utils/JmhHelper.scala 0.00% <0.00%> (ø)
..._4paradigm/openmldb/batch/utils/GraphvizUtil.scala 40.90% <0.00%> (ø)
...b/sdk/impl/BatchCallablePreparedStatementImpl.java 0.00% <0.00%> (ø)
...com/_4paradigm/openmldb/batch/nodes/JoinPlan.scala 49.62% <0.00%> (ø)
... and 142 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

SDK Test Report

  79 files    79 suites   6m 34s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 2fdd3d8.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   55m 16s ⏱️
  9 755 tests   9 748 ✔️ 7 💤 0
14 356 runs  14 349 ✔️ 7 💤 0

Results for commit 2fdd3d8.

@dl239 dl239 changed the title Removed duplicated compile_proto refactor: removed duplicated compile_proto Aug 24, 2022
@dl239 dl239 linked an issue Aug 24, 2022 that may be closed by this pull request
@dl239 dl239 enabled auto-merge (squash) August 24, 2022 02:18
@dl239 dl239 merged commit 5aab6de into 4paradigm:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated compile_proto from src/CMakeLists.txt
3 participants