fix: openmldb-import curator version and docs #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #2384 +/- ##
=========================================
Coverage 75.91% 75.91%
Complexity 368 368
=========================================
Files 629 629
Lines 119710 119710
Branches 1036 1036
=========================================
+ Hits 90872 90882 +10
+ Misses 28622 28612 -10
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aceforeverd
reviewed
Aug 22, 2022
| <artifactId>apache-curator</artifactId> | ||
| <version>5.1.0</version> | ||
| <type>pom</type> | ||
| <artifactId>curator-client</artifactId> |
There was a problem hiding this comment.
many module has deps to curator, it is better to define curator version in a single place( the parent pom) later.
Should we exclude zookeeper as explained in https://curator.apache.org/zk-compatibility-34.html ?
There was a problem hiding this comment.
openmldb-import is not a submodule now. Maybe later?
Excluding zookeeper is ok, we can discuss it in a new issue.
dl239
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2377