Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(udf): how to generate udf documents (udfs_8h.md) #2379

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Aug 19, 2022

Uncompleted.

@github-actions github-actions bot added documentation Improvements or additions to documentation execute-engine hybridse sql engine labels Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #2379 (e0b0c79) into main (a6f5118) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2379      +/-   ##
============================================
+ Coverage     75.90%   75.92%   +0.02%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119721   119721              
  Branches       1044     1044              
============================================
+ Hits          90874    90898      +24     
+ Misses        28631    28607      -24     
  Partials        216      216              
Impacted Files Coverage Δ
...ridse/src/udf/default_defs/window_functions_def.cc 73.91% <ø> (ø)
hybridse/src/udf/default_udf_library.cc 96.97% <ø> (ø)
src/storage/aggregator.cc 78.40% <0.00%> (-1.24%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.68% <0.00%> (-0.16%) ⬇️
src/storage/mem_table.cc 90.10% <0.00%> (-0.15%) ⬇️
hybridse/src/vm/runner.cc 68.10% <0.00%> (-0.04%) ⬇️
src/tablet/tablet_impl.cc 61.65% <0.00%> (-0.03%) ⬇️
src/nameserver/name_server_impl.cc 42.82% <0.00%> (+0.15%) ⬆️
src/zk/dist_lock.cc 83.33% <0.00%> (+1.51%) ⬆️
src/base/file_util.h 80.74% <0.00%> (+1.60%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

HybridSE Linux Test Report

19 669 tests   19 667 ✔️  6m 22s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit e0b0c79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

HybridSE Mac Test Report

19 669 tests   19 667 ✔️  7m 11s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit e0b0c79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

Linux Test Report

       55 files       200 suites   55m 10s ⏱️
  9 755 tests   9 748 ✔️ 7 💤 0
14 356 runs  14 349 ✔️ 7 💤 0

Results for commit e0b0c79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

SDK Test Report

  79 files    79 suites   7m 45s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit e0b0c79.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the build openmldb compiling and installing label Aug 22, 2022
@aceforeverd
Copy link
Collaborator Author

merge after #2382

- fix the generating python script
- adopt poetry for reproducible build
simply type `make udf_doc_gen`
@lumianph
Copy link
Collaborator

help review this pr in the pr meeting @zhanghaohit @vagetablechicken

@aceforeverd
Copy link
Collaborator Author

PR has reviewed this morning. Now it is necessary to review the changes of udf documents. It added new udf functions, and fixed many syntax errors.

@zhanghaohit
Copy link
Collaborator

@aceforeverd if we have multiple RegisterExternal, e.g., RegisterExternal("ilike_match"), it seems that it only extracts the first doc and totally ignoring the later docs with same udf name?

@aceforeverd
Copy link
Collaborator Author

@aceforeverd if we have multiple RegisterExternal, e.g., RegisterExternal("ilike_match"), it seems that it only extracts the first doc and totally ignoring the later docs with same udf name?

Mostly, yes, .doc string is missing for the second and later, except Supported Types includes all overloads.
It should be issue to export_udf_info or export_udf_doc.py, I'll track it elsewhere.

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 5372510 into 4paradigm:main Aug 25, 2022
@aceforeverd aceforeverd deleted the docs-udf-doc-gen branch August 25, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing documentation Improvements or additions to documentation execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants