Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rpc request timeout in CLI and Python SDK #2371

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Aug 18, 2022

Closes #2347

request_timeout for CLI, request_timeout_ms for others

@github-actions github-actions bot added documentation Improvements or additions to documentation sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet labels Aug 18, 2022
@vagetablechicken vagetablechicken requested review from dl239 and aceforeverd and removed request for dl239 August 18, 2022 09:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

SDK Test Report

  79 files    79 suites   8m 22s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 089cf90.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2371 (089cf90) into main (16a90c0) will increase coverage by 0.06%.
The diff coverage is 73.19%.

@@             Coverage Diff              @@
##               main    #2371      +/-   ##
============================================
+ Coverage     75.86%   75.92%   +0.06%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119286   119756     +470     
  Branches       1022     1044      +22     
============================================
+ Hits          90491    90926     +435     
- Misses        28579    28614      +35     
  Partials        216      216              
Impacted Files Coverage Δ
python/openmldb_sdk/test/case_conf.py 100.00% <ø> (ø)
src/cmd/sql_cmd.h 25.36% <0.00%> (-0.76%) ⬇️
src/sdk/sql_cluster_router.h 0.00% <0.00%> (ø)
src/sdk/sql_cluster_router.cc 57.14% <67.74%> (+0.07%) ⬆️
python/openmldb_sdk/test/dbapi_test.py 98.18% <100.00%> (+0.30%) ⬆️
python/openmldb_sdk/test/sdk_smoke_test.py 98.57% <100.00%> (+0.13%) ⬆️
python/openmldb_sdk/test/sqlalchemy_api_test.py 97.36% <100.00%> (+0.70%) ⬆️
src/sdk/sql_router.h 42.85% <100.00%> (+9.52%) ⬆️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
...4paradigm/openmldb/batch/api/OpenmldbSession.scala 60.39% <0.00%> (-1.23%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

Linux Test Report

       55 files       200 suites   56m 41s ⏱️
  9 755 tests   9 748 ✔️ 7 💤 0
14 356 runs  14 349 ✔️ 7 💤 0

Results for commit 089cf90.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit 429c685 into 4paradigm:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli support set rpc request timeout
4 participants