-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support rpc request timeout in CLI and Python SDK #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
sdk
openmldb java/python sdk
storage-engine
openmldb storage engine. nameserver & tablet
labels
Aug 18, 2022
vagetablechicken
requested review from
dl239 and
aceforeverd
and removed request for
dl239
August 18, 2022 09:07
Codecov Report
@@ Coverage Diff @@
## main #2371 +/- ##
============================================
+ Coverage 75.86% 75.92% +0.06%
Complexity 368 368
============================================
Files 629 629
Lines 119286 119756 +470
Branches 1022 1044 +22
============================================
+ Hits 90491 90926 +435
- Misses 28579 28614 +35
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dl239
approved these changes
Aug 23, 2022
tobegit3hub
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aceforeverd
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
sdk
openmldb java/python sdk
storage-engine
openmldb storage engine. nameserver & tablet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2347
request_timeout for CLI, request_timeout_ms for others