Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the compile warning of openmldb-batch #2368

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

TBCCC
Copy link
Contributor

@TBCCC TBCCC commented Aug 18, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Resolved Resolve the compile warning of openmldb-batch #1320

  • What is the new behavior (if this is a feature change)?
    None

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Aug 18, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub changed the title fix: Resolve the compile warning of openmldb-batch fix: resolve the compile warning of openmldb-batch Aug 18, 2022
@tobegit3hub tobegit3hub self-assigned this Aug 18, 2022
@tobegit3hub tobegit3hub added this to the v0.7 milestone Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2368 (7514834) into main (16a90c0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2368      +/-   ##
============================================
- Coverage     75.86%   75.85%   -0.01%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119286   119285       -1     
  Branches       1022     1036      +14     
============================================
- Hits          90491    90485       -6     
- Misses        28579    28584       +5     
  Partials        216      216              
Impacted Files Coverage Δ
..._4paradigm/openmldb/batch/utils/DataTypeUtil.scala 32.00% <ø> (+0.31%) ⬆️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.30% <100.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/replica/replicate_node.cc 74.86% <0.00%> (-3.36%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.06%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/nameserver/name_server_impl.cc 42.65% <0.00%> (-0.16%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

SDK Test Report

  79 files    79 suites   7m 53s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 7514834.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   54m 26s ⏱️
  9 694 tests   9 687 ✔️ 7 💤 0
14 265 runs  14 258 ✔️ 7 💤 0

Results for commit 7514834.

@dl239 dl239 merged commit f7a68db into 4paradigm:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve the compile warning of openmldb-batch
3 participants