Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce one memory copy for unsaferow window project #2364

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added this to the v0.7 milestone Aug 17, 2022
@tobegit3hub tobegit3hub self-assigned this Aug 17, 2022
@github-actions github-actions bot added batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine labels Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2364 (81a1290) into main (16a90c0) will decrease coverage by 0.01%.
The diff coverage is 27.27%.

@@             Coverage Diff              @@
##               main    #2364      +/-   ##
============================================
- Coverage     75.86%   75.84%   -0.02%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119286   119293       +7     
  Branches       1022     1036      +14     
============================================
- Hits          90491    90481      -10     
- Misses        28579    28596      +17     
  Partials        216      216              
Impacted Files Coverage Δ
hybridse/src/vm/core_api.cc 15.50% <0.00%> (-0.65%) ⬇️
hybridse/src/vm/core_api.h 0.00% <ø> (ø)
...aradigm/openmldb/batch/window/WindowComputer.scala 75.92% <100.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 65.69% <0.00%> (-0.68%) ⬇️
src/storage/mem_table.cc 90.10% <0.00%> (-0.15%) ⬇️
src/nameserver/name_server_impl.cc 42.67% <0.00%> (-0.14%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

SDK Test Report

  79 files    79 suites   7m 29s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 81a1290.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

HybridSE Linux Test Report

19 629 tests   19 627 ✔️  6m 52s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 81a1290.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

HybridSE Mac Test Report

19 629 tests   19 627 ✔️  7m 12s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 81a1290.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

Linux Test Report

       55 files       200 suites   54m 2s ⏱️
  9 694 tests   9 687 ✔️ 7 💤 0
14 265 runs  14 258 ✔️ 7 💤 0

Results for commit 81a1290.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub requested a review from dl239 August 18, 2022 07:21
@tobegit3hub tobegit3hub merged commit 5e41dad into 4paradigm:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core when enabling UnsafeRowOpt with multiple threads in Yarn cluster
3 participants