-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce one memory copy for unsaferow window project #2364
Merged
tobegit3hub
merged 2 commits into
4paradigm:main
from
tobegit3hub:feat/add_unsafe_window_project_bytes_api
Aug 22, 2022
Merged
feat: reduce one memory copy for unsaferow window project #2364
tobegit3hub
merged 2 commits into
4paradigm:main
from
tobegit3hub:feat/add_unsafe_window_project_bytes_api
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
Aug 17, 2022
- Resolve Core when enabling UnsafeRowOpt with multiple threads in Yarn cluster #2303 and improve performance by reducing one memory copy.
Codecov Report
@@ Coverage Diff @@
## main #2364 +/- ##
============================================
- Coverage 75.86% 75.84% -0.02%
Complexity 368 368
============================================
Files 629 629
Lines 119286 119293 +7
Branches 1022 1036 +14
============================================
- Hits 90491 90481 -10
- Misses 28579 28596 +17
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aceforeverd
reviewed
Aug 18, 2022
dl239
approved these changes
Aug 19, 2022
aceforeverd
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.