Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): use conventional-changelog-cli to generate changelog #2363

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Aug 17, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #2332

Use conventional-changelog-cli to generate the new changelog (draft version).

The workflow is for local use only (no automated CI/CD):

  1. first run ? npm install
  2. append the new changelog: npm run-script changelog
  3. checkout CHANGELOG.md and tweak manully
  4. you should change other documents and version number manully
  5. commit change and open the release PR

@aceforeverd aceforeverd requested a review from lumianph August 17, 2022 04:39
@aceforeverd aceforeverd added the code-standards code style/convention things label Aug 17, 2022
@aceforeverd aceforeverd added this to the v0.7 milestone Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2363 (91c18e1) into main (f368158) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2363      +/-   ##
============================================
- Coverage     75.87%   75.85%   -0.03%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119285   119285              
  Branches       1022     1022              
============================================
- Hits          90509    90480      -29     
- Misses        28560    28589      +29     
  Partials        216      216              
Impacted Files Coverage Δ
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
hybridse/src/vm/local_tablet_handler.h 68.88% <0.00%> (-2.23%) ⬇️
src/storage/schema.h 84.55% <0.00%> (-1.63%) ⬇️
hybridse/src/vm/runner.cc 68.14% <0.00%> (-1.16%) ⬇️
hybridse/src/codec/type_codec.cc 74.88% <0.00%> (-0.92%) ⬇️
hybridse/src/vm/engine.cc 76.48% <0.00%> (-0.55%) ⬇️
hybridse/include/vm/mem_catalog.h 73.01% <0.00%> (-0.35%) ⬇️
src/tablet/tablet_impl.cc 61.52% <0.00%> (-0.35%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/codec/codec.cc 72.55% <0.00%> (-0.26%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lumianph lumianph removed their request for review August 17, 2022 05:19
@lumianph
Copy link
Collaborator

is the package-lock.json necessary?

@github-actions
Copy link
Contributor

SDK Test Report

  79 files    79 suites   7m 56s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 91c18e1.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   54m 10s ⏱️
  9 694 tests   9 687 ✔️ 7 💤 0
14 265 runs  14 258 ✔️ 7 💤 0

Results for commit 91c18e1.

@aceforeverd
Copy link
Collaborator Author

is the package-lock.json necessary?

Lock dependency and also dependency of dependency, it should be more reliable after keep the lock file.

@lumianph lumianph requested a review from dl239 August 18, 2022 01:35
@vagetablechicken
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #2332

Use conventional-changelog-cli to generate the new changelog (draft version).

The workflow is for local use only (no automated CI/CD):

1. first run ? `npm install`

2. append the new changelog: `npm run-script changelog`

3. checkout `CHANGELOG.md` and tweak manully

4. you should change other documents and version number manully

5. commit change and open the release PR

How about add the description to a file in docs? or another place.

@aceforeverd
Copy link
Collaborator Author

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #2332
Use conventional-changelog-cli to generate the new changelog (draft version).
The workflow is for local use only (no automated CI/CD):

1. first run ? `npm install`

2. append the new changelog: `npm run-script changelog`

3. checkout `CHANGELOG.md` and tweak manully

4. you should change other documents and version number manully

5. commit change and open the release PR

How about add the description to a file in docs? or another place.

Part of Release policy from maintenance. Will list it in #1811

@aceforeverd aceforeverd merged commit 4e3b2f9 into 4paradigm:main Aug 25, 2022
@aceforeverd aceforeverd deleted the feat-gen-changelog branch August 25, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-standards code style/convention things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools or workflow to generate release note
3 participants