Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update TaskManagerClient.java #2310

Merged
merged 1 commit into from
Aug 10, 2022
Merged

refactor: update TaskManagerClient.java #2310

merged 1 commit into from
Aug 10, 2022

Conversation

hv789
Copy link
Contributor

@hv789 hv789 commented Aug 6, 2022

Changed "Submit job to show batch version" to "Submit job to get job log".

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • docs update

  • What is the current behavior? (You can also link to an open issue here)

  • comment is correct now.

  • What is the new behavior (if this is a feature change)?

Changed "Submit job to show batch version" to "Submit job to get job log".
@github-actions github-actions bot added the task-manager openmldb taskmanager label Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #2310 (1098f86) into main (8b57582) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2310      +/-   ##
============================================
- Coverage     75.66%   75.65%   -0.02%     
  Complexity      368      368              
============================================
  Files           627      627              
  Lines        118215   118215              
  Branches       1022     1022              
============================================
- Hits          89453    89440      -13     
- Misses        28546    28559      +13     
  Partials        216      216              
Impacted Files Coverage Δ
...openmldb/taskmanager/client/TaskManagerClient.java 0.00% <ø> (ø)
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/catalog/tablet_catalog.cc 71.61% <0.00%> (-0.80%) ⬇️
src/client/tablet_client.cc 56.04% <0.00%> (-0.12%) ⬇️
src/nameserver/name_server_impl.cc 42.67% <0.00%> (-0.09%) ⬇️
src/tablet/tablet_impl.cc 61.50% <0.00%> (-0.08%) ⬇️
src/catalog/client_manager.cc 42.49% <0.00%> (+0.28%) ⬆️
src/sdk/db_sdk.cc 66.14% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

SDK Test Report

  79 files    79 suites   6m 49s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 1098f86.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Linux Test Report

       55 files       200 suites   52m 10s ⏱️
  9 254 tests   9 250 ✔️ 4 💤 0
13 615 runs  13 611 ✔️ 4 💤 0

Results for commit 1098f86.

@hv789 hv789 mentioned this pull request Aug 6, 2022
@dl239 dl239 changed the title Update TaskManagerClient.java refactor: update TaskManagerClient.java Aug 10, 2022
@dl239 dl239 requested a review from tobegit3hub August 10, 2022 10:03
@dl239 dl239 enabled auto-merge (squash) August 10, 2022 10:04
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 2ef6377 into 4paradigm:main Aug 10, 2022
@dl239 dl239 linked an issue Aug 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix comment of getJobLog
3 participants