Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addtid and pid to RollWLogFile log message #2306

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 5, 2022

Signed-off-by: Ben Ye [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add tid and pid to RollWLogFile log message.

  • What is the current behavior? (You can also link to an open issue here)
    fixes Add tid and pid to RollWLogFile log message #2268

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #2306 (efc6653) into main (8b57582) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2306      +/-   ##
============================================
+ Coverage     75.66%   75.68%   +0.01%     
  Complexity      368      368              
============================================
  Files           627      627              
  Lines        118215   118215              
  Branches       1022     1022              
============================================
+ Hits          89453    89471      +18     
+ Misses        28546    28528      -18     
  Partials        216      216              
Impacted Files Coverage Δ
src/replica/log_replicator.cc 81.87% <100.00%> (ø)
src/catalog/tablet_catalog.cc 71.61% <0.00%> (-0.80%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.36% <0.00%> (-0.32%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (-0.07%) ⬇️
hybridse/src/vm/runner.cc 67.74% <0.00%> (-0.04%) ⬇️
src/client/tablet_client.cc 56.15% <0.00%> (ø)
src/tablet/tablet_impl.cc 61.65% <0.00%> (+0.07%) ⬆️
src/sdk/db_sdk.cc 66.36% <0.00%> (+0.67%) ⬆️
src/rpc/rpc_client.h 90.54% <0.00%> (+1.35%) ⬆️
src/log/log_reader.cc 79.11% <0.00%> (+2.64%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

SDK Test Report

  79 files    79 suites   6m 26s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit efc6653.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Linux Test Report

       55 files       200 suites   52m 3s ⏱️
  9 254 tests   9 250 ✔️ 4 💤 0
13 615 runs  13 611 ✔️ 4 💤 0

Results for commit efc6653.

@dl239 dl239 requested a review from vagetablechicken August 7, 2022 12:04
@dl239 dl239 requested a review from tobegit3hub August 10, 2022 10:02
@dl239 dl239 enabled auto-merge (squash) August 10, 2022 10:08
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 81cd743 into 4paradigm:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tid and pid to RollWLogFile log message
3 participants