Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2235 enable trace #2292

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Aug 3, 2022

close #2235

when set @@enable_trace = 'true';, should work for

  • sql query
  • deploy
  • select into

For any other cmd, interface is ready, whether it prints trace depends on implementation, fix it just by putting info into status.trace

should work with
- query
- deploy
- select into

not sure work for insert, but the interface is set
@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2292 (f276360) into main (00e229a) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##               main    #2292      +/-   ##
============================================
- Coverage     75.73%   75.71%   -0.02%     
  Complexity      368      368              
============================================
  Files           626      627       +1     
  Lines        118148   118170      +22     
  Branches       1048     1050       +2     
============================================
- Hits          89476    89472       -4     
- Misses        28456    28482      +26     
  Partials        216      216              
Impacted Files Coverage Δ
hybridse/include/sdk/base.h 18.51% <0.00%> (-0.72%) ⬇️
src/cmd/sql_cmd.h 26.11% <0.00%> (-0.40%) ⬇️
src/sdk/sql_cluster_router.cc 56.63% <50.00%> (+0.04%) ⬆️
src/sdk/db_sdk.cc 66.14% <0.00%> (-4.27%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
src/client/ns_client.cc 46.94% <0.00%> (-0.15%) ⬇️
...radigm/openmldb/taskmanager/util/VersionUtil.scala 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...aradigm/openmldb/taskmanager/utils/VersionCli.java 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e229a...f276360. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

HybridSE Linux Test Report

19 290 tests   19 288 ✔️  5m 26s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit f276360.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

SDK Test Report

  77 files    77 suites   6m 4s ⏱️
166 tests 164 ✔️ 2 💤 0
208 runs  206 ✔️ 2 💤 0

Results for commit f276360.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

HybridSE Mac Test Report

19 290 tests   19 288 ✔️  7m 44s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit f276360.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Linux Test Report

       55 files       200 suites   52m 22s ⏱️
  9 254 tests   9 250 ✔️ 4 💤 0
13 615 runs  13 611 ✔️ 4 💤 0

Results for commit f276360.

Copy link
Contributor

@wuyou10206 wuyou10206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked,deploy/select/select...into when an error occurs, CLI prints trace back, but at the same time, a log appears, and the problem has been issued

@aceforeverd
Copy link
Collaborator Author

checked,deploy/select/select...into when an error occurs, CLI prints trace back, but at the same time, a log appears, and the problem has been issued

issued here #2148 (comment)

@aceforeverd aceforeverd merged commit cba8f76 into 4paradigm:main Aug 4, 2022
@aceforeverd aceforeverd deleted the fix-2235-enable-trace branch August 4, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_trace is broken for cmd like sql query
3 participants