Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unsaferowopt with string columns #2273

Conversation

tobegit3hub
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #2273 (f363e7f) into main (165034f) will decrease coverage by 0.09%.
The diff coverage is 48.83%.

@@             Coverage Diff              @@
##               main    #2273      +/-   ##
============================================
- Coverage     75.79%   75.69%   -0.10%     
- Complexity      354      368      +14     
============================================
  Files           619      627       +8     
  Lines        117583   118205     +622     
  Branches       1039     1022      -17     
============================================
+ Hits          89126    89481     +355     
- Misses        28246    28508     +262     
- Partials        211      216       +5     
Impacted Files Coverage Δ
hybridse/src/vm/core_api.cc 16.14% <0.00%> (ø)
hybridse/src/vm/core_api.h 0.00% <ø> (ø)
...4paradigm/openmldb/batch/utils/UnsafeRowUtil.scala 44.73% <42.10%> (-39.48%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 60.81% <53.84%> (-0.18%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.36% <54.54%> (-0.13%) ⬇️
...paradigm/openmldb/batch/nodes/RowProjectPlan.scala 80.55% <66.66%> (-1.97%) ⬇️
...aradigm/openmldb/batch/window/WindowComputer.scala 75.92% <66.66%> (-5.81%) ⬇️
...4paradigm/openmldb/batch/OpenmldbBatchConfig.scala 86.66% <100.00%> (ø)
.../com/_4paradigm/openmldb/batch/SparkRowCodec.scala 57.47% <100.00%> (-9.98%) ⬇️
src/sdk/sql_cluster_router.h 0.00% <0.00%> (-81.09%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

SDK Test Report

  79 files    79 suites   6m 45s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit f363e7f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

Linux Test Report

       55 files       200 suites   53m 4s ⏱️
  9 254 tests   9 250 ✔️ 4 💤 0
13 615 runs  13 611 ✔️ 4 💤 0

Results for commit f363e7f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

HybridSE Linux Test Report

19 290 tests   19 288 ✔️  5m 54s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit f363e7f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

HybridSE Mac Test Report

19 290 tests   19 288 ✔️  7m 2s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit f363e7f.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub self-assigned this Aug 2, 2022
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Aug 2, 2022
@tobegit3hub
Copy link
Collaborator Author

@lumianph
Copy link
Collaborator

lumianph commented Aug 9, 2022

close #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants