Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improved sql/dql/join in en #2238

Merged
merged 12 commits into from
Aug 9, 2022
Merged

Conversation

michelle-qinqin
Copy link
Contributor

@michelle-qinqin michelle-qinqin commented Jul 25, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    change splice=>join or concatenation
    added sql examples
    updated the boundary table

fixed format error on line 9 in zh version

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 25, 2022
@lumianph lumianph self-requested a review August 3, 2022 01:29
Copy link
Collaborator

@lumianph lumianph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能有些格式(比如example不要作为title formatting),中文文档你再检查一下

docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/en/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/JOIN_CLAUSE.md Outdated Show resolved Hide resolved
@michelle-qinqin
Copy link
Contributor Author

中英文文档的格式均已修改。

@michelle-qinqin
Copy link
Contributor Author

所有的 matching rows 均已修改为mtached rows

@michelle-qinqin
Copy link
Contributor Author

中英文文档的JOIN、WINDOW和中文的SELECT概述的Online Serving均已修改。
英文的SELECT概述在另一个PR中修改:#229

@lumianph lumianph merged commit 2655ace into 4paradigm:main Aug 9, 2022
@michelle-qinqin michelle-qinqin deleted the en_join branch August 9, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants