-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: repaint the figures and update the table in sql/dql/window_clause #2201
Conversation
since there are quite a lot changes in this PR, let's review this PR in the next PR meeting @michelle-qinqin @dl239 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 多了个 ppt ?
- window_max_size.png:
4-5s preceding
->5s preceding
ppt是可编辑的图片源文件,之前没有找到可编辑的原文件,我就重画了一个,传上来也方便后续修改。 |
@aceforeverd 图片已修改,感谢指正~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window_union_2_table: 从下往上第三行应该是 1s preceding
那应该保存一个就可以。原版图片应该使用 draw.io 画的 |
好的,我删掉en里的可以吗 |
都可以 |
window_union_2_table 有效窗口内倒数第三行已修正 |
TODO later: draw a graph for |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
repaint the figures and update the table in sql/sql/window_clause