Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: repaint the figures and update the table in sql/dql/window_clause #2201

Merged
merged 12 commits into from
Jul 28, 2022

Conversation

michelle-qinqin
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    repaint the figures and update the table in sql/sql/window_clause

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2022
@lumianph
Copy link
Collaborator

since there are quite a lot changes in this PR, let's review this PR in the next PR meeting @michelle-qinqin @dl239
@aceforeverd @vagetablechicken pls help carefully review the changes, especially the figures

Copy link
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 多了个 ppt ?
  • window_max_size.png: 4-5s preceding -> 5s preceding

@michelle-qinqin
Copy link
Contributor Author

ppt是可编辑的图片源文件,之前没有找到可编辑的原文件,我就重画了一个,传上来也方便后续修改。
maxsize的那个是我没注意到,我重新画一下。

@michelle-qinqin
Copy link
Contributor Author

@aceforeverd 图片已修改,感谢指正~

Copy link
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window_union_2_table: 从下往上第三行应该是 1s preceding

@aceforeverd
Copy link
Collaborator

ppt是可编辑的图片源文件,之前没有找到可编辑的原文件,我就重画了一个,传上来也方便后续修改。 maxsize的那个是我没注意到,我重新画一下。

那应该保存一个就可以。原版图片应该使用 draw.io 画的

@michelle-qinqin
Copy link
Contributor Author

w.i

好的,我删掉en里的可以吗

@aceforeverd
Copy link
Collaborator

w.i

好的,我删掉en里的可以吗

都可以

@michelle-qinqin
Copy link
Contributor Author

window_union_2_table 有效窗口内倒数第三行已修正
en版本里的ppt文件已删除

@michelle-qinqin michelle-qinqin changed the title docs: repaint the figures and update the table in sql/sql/window_clause docs: repaint the figures and update the table in sql/dql/window_clause Jul 25, 2022
@aceforeverd
Copy link
Collaborator

TODO later: draw a graph for exclude current_row after #2195

@lumianph lumianph merged commit ec68f2e into 4paradigm:main Jul 28, 2022
@michelle-qinqin michelle-qinqin deleted the dql_window branch July 28, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants