Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove converttype function in sdk/sql_insert_row.h #2190

Merged

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

SDK Test Report

  77 files    77 suites   6m 32s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit c8ea21f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2190 (c8ea21f) into main (c02d494) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2190   +/-   ##
=========================================
  Coverage     75.74%   75.75%           
  Complexity      353      353           
=========================================
  Files           619      619           
  Lines        117303   117303           
  Branches       1039     1039           
=========================================
+ Hits          88857    88866    +9     
+ Misses        28235    28226    -9     
  Partials        211      211           
Impacted Files Coverage Δ
src/sdk/sql_insert_row.h 40.00% <ø> (ø)
src/zk/zk_client.cc 83.37% <0.00%> (-1.56%) ⬇️
src/sdk/db_sdk.cc 63.90% <0.00%> (-0.68%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/tablet/tablet_impl.cc 61.15% <0.00%> (-0.25%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
hybridse/src/vm/runner.cc 67.78% <0.00%> (+0.03%) ⬆️
src/client/tablet_client.cc 56.15% <0.00%> (+0.11%) ⬆️
src/nameserver/name_server_impl.cc 42.81% <0.00%> (+0.15%) ⬆️
src/storage/aggregator.cc 76.53% <0.00%> (+1.31%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02d494...c8ea21f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

Linux Test Report

       55 files       200 suites   52m 7s ⏱️
  9 229 tests   9 225 ✔️ 4 💤 0
13 580 runs  13 576 ✔️ 4 💤 0

Results for commit c8ea21f.

♻️ This comment has been updated with latest results.

@dl239 dl239 requested a review from vagetablechicken July 18, 2022 09:50
@vagetablechicken vagetablechicken merged commit d083b89 into 4paradigm:main Jul 19, 2022
@mangoGoForward mangoGoForward deleted the fix/remove-unused-function branch July 19, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete ConvertType function from sdk/sql_insert_row.h
3 participants