Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): return result set for the new query api #2189

Merged
merged 2 commits into from
Jul 28, 2022
Merged

feat(api-server): return result set for the new query api #2189

merged 2 commits into from
Jul 28, 2022

Conversation

qsliu2017
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #2127

  • What is the current behavior? (You can also link to an open issue here)

POST /dbs/:db_name only return "code" and "msg"

  • What is the new behavior (if this is a feature change)?

return query result like

{ "code": 0, "msg": "ok", "data": [[1, "bb"]] }

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

Linux Test Report

       55 files       200 suites   52m 37s ⏱️
  9 242 tests   9 238 ✔️ 4 💤 0
13 598 runs  13 594 ✔️ 4 💤 0

Results for commit 6241930.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2189 (6241930) into main (28d2833) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2189      +/-   ##
============================================
- Coverage     75.79%   75.74%   -0.06%     
  Complexity      354      354              
============================================
  Files           619      619              
  Lines        117581   117628      +47     
  Branches       1039     1039              
============================================
- Hits          89123    89098      -25     
- Misses        28247    28319      +72     
  Partials        211      211              
Impacted Files Coverage Δ
src/apiserver/api_server_impl.cc 0.00% <0.00%> (ø)
src/apiserver/api_server_impl.h 0.00% <0.00%> (ø)
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/storage/schema.h 84.55% <0.00%> (-1.63%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client.cc 83.11% <0.00%> (-1.04%) ⬇️
src/sdk/db_sdk.cc 63.90% <0.00%> (-0.68%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d2833...6241930. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

SDK Test Report

  77 files    77 suites   7m 15s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit 6241930.

♻️ This comment has been updated with latest results.

@aceforeverd
Copy link
Collaborator

api_server_test failed ?

@qsliu2017
Copy link
Contributor Author

api_server_test failed ?

In the added test case, I try to send a query to API server, but it turns out Fail to get TaskManager client.

Seems like the API server test env do not have a real database? need helps @aceforeverd

@aceforeverd
Copy link
Collaborator

api_server_test failed ?

In the added test case, I try to send a query to API server, but it turns out Fail to get TaskManager client.

Seems like the API server test env do not have a real database? need helps @aceforeverd

I'll check today

@aceforeverd
Copy link
Collaborator

ospp - Golang SDK

src/apiserver/api_server_test.cc Outdated Show resolved Hide resolved
@aceforeverd aceforeverd merged commit d330722 into 4paradigm:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(api-server): return result set for the new query api
4 participants