Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gitpod #2185

Merged
merged 3 commits into from
Aug 16, 2022
Merged

feat: support gitpod #2185

merged 3 commits into from
Aug 16, 2022

Conversation

qsliu2017
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    developers can start coding at https://gitpod.io/#/github.com/4paradigm/OpenMLDB (my forked repo has setup gitpod)
    this reduces dependency install and first-time building

need helps:

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2185 (c280643) into main (6e691e8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2185   +/-   ##
=========================================
  Coverage     75.75%   75.76%           
  Complexity      367      367           
=========================================
  Files           624      624           
  Lines        118073   118073           
  Branches       1048     1048           
=========================================
+ Hits          89446    89453    +7     
+ Misses        28410    28403    -7     
  Partials        217      217           
Impacted Files Coverage Δ
src/sdk/db_sdk.cc 65.69% <0.00%> (-0.90%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (-0.26%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
src/client/ns_client.cc 46.94% <0.00%> (-0.15%) ⬇️
src/nameserver/name_server_impl.cc 42.72% <0.00%> (-0.10%) ⬇️
hybridse/src/vm/runner.cc 67.74% <0.00%> (-0.04%) ⬇️
src/tablet/tablet_impl.cc 61.70% <0.00%> (+0.07%) ⬆️
src/log/log_reader.cc 79.11% <0.00%> (+2.64%) ⬆️
src/replica/replicate_node.cc 78.77% <0.00%> (+4.46%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e691e8...c280643. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

SDK Test Report

  77 files    77 suites   6m 0s ⏱️
166 tests 164 ✔️ 2 💤 0
208 runs  206 ✔️ 2 💤 0

Results for commit c280643.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

Linux Test Report

       55 files       200 suites   53m 29s ⏱️
  9 244 tests   9 240 ✔️ 4 💤 0
13 600 runs  13 596 ✔️ 4 💤 0

Results for commit c280643.

♻️ This comment has been updated with latest results.

@qsliu2017 qsliu2017 requested a review from aceforeverd July 17, 2022 05:50
@qsliu2017 qsliu2017 requested a review from aceforeverd July 18, 2022 03:39
@aceforeverd
Copy link
Collaborator

@lumianph see if we're ok to install gitpod ? gitpod is similar to GitHub Code Space but is in public service so probably more developer can use it than code space

@gitpod-for-oss
Copy link
Contributor

@lumianph see if we're ok to install gitpod? gitpod is similar to GitHub Code Space but is in public service so probably more developer can use it than code space

Installing Gitpod GitHub App to this repository will help you to enable prebuilds to keep always ready to code.

Also, In Gitpod you can use Multiple IDEs & not just VS Code. Detailed difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants