Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support delete #2183

Merged
merged 20 commits into from
Jul 28, 2022
Merged

feat: support delete #2183

merged 20 commits into from
Jul 28, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 16, 2022

  • support delete sql in hybridse and sdk
  • add DeletePreparedStatement to jdbc

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 16, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2183 (c35e0ee) into main (2ddaca9) will decrease coverage by 0.06%.
The diff coverage is 62.09%.

@@             Coverage Diff              @@
##               main    #2183      +/-   ##
============================================
- Coverage     75.79%   75.73%   -0.07%     
- Complexity      354      367      +13     
============================================
  Files           619      624       +5     
  Lines        117581   118100     +519     
  Branches       1039     1048       +9     
============================================
+ Hits          89124    89446     +322     
- Misses        28246    28437     +191     
- Partials        211      217       +6     
Impacted Files Coverage Δ
hybridse/include/node/node_manager.h 100.00% <ø> (ø)
src/apiserver/api_server_impl.cc 0.00% <0.00%> (ø)
src/client/taskmanager_client.h 0.00% <ø> (ø)
src/sdk/sql_cluster_router.h 0.00% <ø> (-81.09%) ⬇️
src/sdk/sql_router.h 33.33% <ø> (ø)
...openmldb/sdk/impl/DeletePreparedStatementImpl.java 24.68% <24.68%> (ø)
src/sdk/sql_delete_row.cc 37.50% <37.50%> (ø)
src/sdk/node_adapter.cc 51.77% <56.52%> (+0.31%) ⬆️
src/sdk/sql_cluster_router.cc 56.57% <65.84%> (+1.09%) ⬆️
src/schema/schema_adapter.cc 48.83% <66.66%> (+6.24%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddaca9...c35e0ee. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

SDK Test Report

  77 files    77 suites   5m 47s ⏱️
166 tests 164 ✔️ 2 💤 0
208 runs  206 ✔️ 2 💤 0

Results for commit c35e0ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

HybridSE Linux Test Report

19 285 tests   19 283 ✔️  5m 36s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit c35e0ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

HybridSE Mac Test Report

19 285 tests   19 283 ✔️  7m 19s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit c35e0ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

Linux Test Report

       55 files       200 suites   52m 18s ⏱️
  9 244 tests   9 240 ✔️ 4 💤 0
13 600 runs  13 596 ✔️ 4 💤 0

Results for commit c35e0ee.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the sdk openmldb java/python sdk label Jul 17, 2022
@dl239 dl239 linked an issue Jul 18, 2022 that may be closed by this pull request
@github-actions github-actions bot added api-server and removed storage-engine openmldb storage engine. nameserver & tablet labels Jul 21, 2022
@dl239 dl239 marked this pull request as ready for review July 21, 2022 11:58
@dl239 dl239 requested a review from aceforeverd July 21, 2022 11:59
@dl239 dl239 merged commit 68e1f7b into 4paradigm:main Jul 28, 2022
@dl239 dl239 deleted the feat/delete branch July 28, 2022 07:20
@lumianph
Copy link
Collaborator

lumianph commented Aug 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server execute-engine hybridse sql engine sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support delete in kafka connector
4 participants