-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support delete #2183
Merged
Merged
feat: support delete #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
execute-engine
hybridse sql engine
storage-engine
openmldb storage engine. nameserver & tablet
labels
Jul 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #2183 +/- ##
============================================
- Coverage 75.79% 75.73% -0.07%
- Complexity 354 367 +13
============================================
Files 619 624 +5
Lines 117581 118100 +519
Branches 1039 1048 +9
============================================
+ Hits 89124 89446 +322
- Misses 28246 28437 +191
- Partials 211 217 +6
Continue to review full report at Codecov.
|
extensions/kafka-connect-jdbc/src/main/java/io/confluent/connect/jdbc/sink/BufferedRecords.java
Outdated
Show resolved
Hide resolved
extensions/kafka-connect-jdbc/src/main/java/io/confluent/connect/jdbc/sink/BufferedRecords.java
Outdated
Show resolved
Hide resolved
extensions/kafka-connect-jdbc/src/main/java/io/confluent/connect/jdbc/sink/BufferedRecords.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
api-server
and removed
storage-engine
openmldb storage engine. nameserver & tablet
labels
Jul 21, 2022
aceforeverd
reviewed
Jul 27, 2022
vagetablechicken
approved these changes
Jul 28, 2022
aceforeverd
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeletePreparedStatement
to jdbc