Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapshot recover for disk table #2174

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

zhanghaohit
Copy link
Collaborator

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2174 (ae23517) into main (6f19e2d) will increase coverage by 0.00%.
The diff coverage is 90.52%.

@@            Coverage Diff             @@
##               main    #2174    +/-   ##
==========================================
  Coverage     75.77%   75.77%            
  Complexity      353      353            
==========================================
  Files           619      619            
  Lines        117268   117486   +218     
  Branches       1039     1039            
==========================================
+ Hits          88857    89024   +167     
- Misses        28200    28251    +51     
  Partials        211      211            
Impacted Files Coverage Δ
src/tablet/tablet_impl.cc 61.38% <75.00%> (+0.06%) ⬆️
src/base/file_util.h 79.14% <80.76%> (+0.76%) ⬆️
src/replica/snapshot_replica_test.cc 91.94% <92.65%> (+0.37%) ⬆️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
hybridse/src/codec/type_codec.cc 74.88% <0.00%> (-0.92%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.63%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-0.45%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f19e2d...ae23517. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Linux Test Report

       55 files       200 suites   53m 19s ⏱️
  9 231 tests   9 227 ✔️ 4 💤 0
13 582 runs  13 578 ✔️ 4 💤 0

Results for commit ae23517.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

SDK Test Report

  77 files    77 suites   6m 10s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit ae23517.

♻️ This comment has been updated with latest results.

@zhanghaohit zhanghaohit requested a review from dl239 July 18, 2022 01:38
@zhanghaohit
Copy link
Collaborator Author

@wuyou10206 pls check and verify if this pr fixes the bug reported

@zhanghaohit zhanghaohit merged commit 0769892 into 4paradigm:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For a single node cluster, the disk table kreloadtableop fails after the tablet is restarted
3 participants