Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support complex spark conf for taskmanager #2170

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added this to the v0.6 milestone Jul 14, 2022
@tobegit3hub tobegit3hub self-assigned this Jul 14, 2022
@github-actions github-actions bot added the task-manager openmldb taskmanager label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2170 (234849c) into main (0c6c665) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2170      +/-   ##
============================================
- Coverage     75.76%   75.74%   -0.02%     
  Complexity      353      353              
============================================
  Files           619      619              
  Lines        117220   117305      +85     
  Branches       1039     1039              
============================================
+ Hits          88809    88854      +45     
- Misses        28200    28240      +40     
  Partials        211      211              
Impacted Files Coverage Δ
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...m/openmldb/taskmanager/spark/SparkJobManager.scala 0.00% <0.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
hybridse/src/udf/literal_traits.h 93.82% <0.00%> (-4.88%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
include/base/type.h 85.48% <0.00%> (-4.35%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6c665...234849c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

SDK Test Report

  77 files    77 suites   6m 15s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit 234849c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Linux Test Report

       55 files       200 suites   53m 12s ⏱️
  9 229 tests   9 225 ✔️ 4 💤 0
13 580 runs  13 576 ✔️ 4 💤 0

Results for commit 234849c.

♻️ This comment has been updated with latest results.

@lumianph lumianph requested a review from wuyou10206 July 18, 2022 03:39
@tobegit3hub tobegit3hub merged commit 4322b34 into 4paradigm:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to pass the config with equality sign for spark config in TaskManager
3 participants