Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hybridse/images file deleted #2158

Merged
merged 21 commits into from
Jul 13, 2022
Merged

Conversation

frazie
Copy link
Contributor

@frazie frazie commented Jul 12, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor: remove hybridse/images #1981

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2158 (c61e721) into main (012db06) will increase coverage by 38.46%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #2158       +/-   ##
=============================================
+ Coverage     37.30%   75.77%   +38.46%     
  Complexity      353      353               
=============================================
  Files           142      618      +476     
  Lines          8508   117171   +108663     
  Branches       1032     1032               
=============================================
+ Hits           3174    88785    +85611     
- Misses         5123    28175    +23052     
  Partials        211      211               
Impacted Files Coverage Δ
hybridse/include/node/type_node.h 91.42% <0.00%> (ø)
...ybridse/src/passes/physical/condition_optimized.cc 79.61% <0.00%> (ø)
src/storage/table_iterator_test.cc 100.00% <0.00%> (ø)
...amples/toydb/src/testing/toydb_engine_test_base.cc 74.00% <0.00%> (ø)
...tistics/query_response_time/query_response_time.cc 94.23% <0.00%> (ø)
src/storage/mem_table_snapshot.h 100.00% <0.00%> (ø)
src/tablet/file_sender.cc 69.56% <0.00%> (ø)
...bridse/src/udf/default_defs/min_by_category_def.cc 100.00% <0.00%> (ø)
hybridse/include/vm/router.h 100.00% <0.00%> (ø)
src/storage/snapshot_test.cc 99.79% <0.00%> (ø)
... and 466 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012db06...c61e721. Read the comment docs.

@dl239 dl239 linked an issue Jul 12, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

SDK Test Report

  76 files    76 suites   5m 59s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit c61e721.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   52m 17s ⏱️
  9 227 tests   9 223 ✔️ 4 💤 0
13 578 runs  13 574 ✔️ 4 💤 0

Results for commit c61e721.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

19 278 tests   19 276 ✔️  5m 56s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit c61e721.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

19 278 tests   19 276 ✔️  7m 2s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit c61e721.

@aceforeverd
Copy link
Collaborator

Pls rebase upon upstream main and remove unnecessary commits

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 4dac6e4 into 4paradigm:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove hybridse/images
4 participants