fix: pass sql file absolute path and fix for yarn-client mode #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
Jul 12, 2022
tobegit3hub
commented
- Resolve Fail to get sql file for yarn-client mode #2150 .
github-actions
bot
added
batch-engine
Codecov Report
@@ Coverage Diff @@
## main #2151 +/- ##
=============================================
+ Coverage 37.30% 75.76% +38.46%
Complexity 353 353
=============================================
Files 142 618 +476
Lines 8508 117173 +108665
Branches 1032 1031 -1
=============================================
+ Hits 3174 88781 +85607
- Misses 5123 28181 +23058
Partials 211 211
Continue to review full report at Codecov.
|
tobegit3hub
commented
Jul 14, 2022
| } else { | ||
| sqlFilePath | ||
| } | ||
|
|
||
| println("tobe1: actualSqlFilePath: " + actualSqlFilePath) |
There was a problem hiding this comment.
Remove the debug code.
dl239
approved these changes
Jul 14, 2022
aceforeverd
approved these changes
Jul 14, 2022
tobegit3hub
added a commit
to tobegit3hub/OpenMLDB
that referenced
this pull request
Jul 20, 2022
…igm#2151) * Pass sql file absolute path and fix for yarn-client mode * Remove the debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.