Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add taskmanager get version api #2102

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Jul 6, 2022
@tobegit3hub tobegit3hub added this to the v0.6 milestone Jul 6, 2022
@tobegit3hub tobegit3hub requested a review from dl239 July 6, 2022 10:21
@tobegit3hub tobegit3hub self-assigned this Jul 6, 2022
@github-actions github-actions bot added storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager labels Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2102 (b45b64a) into main (964a9b9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2102      +/-   ##
============================================
- Coverage     75.79%   75.78%   -0.02%     
  Complexity      347      347              
============================================
  Files           615      616       +1     
  Lines        116921   116940      +19     
  Branches       1015     1019       +4     
============================================
+ Hits          88623    88624       +1     
- Misses        28089    28107      +18     
  Partials        209      209              
Impacted Files Coverage Δ
...openmldb/taskmanager/client/TaskManagerClient.java 0.00% <0.00%> (ø)
...openmldb/taskmanager/server/TaskManagerServer.java 0.00% <ø> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...radigm/openmldb/taskmanager/util/VersionUtil.scala 0.00% <0.00%> (ø)
src/cmd/sql_cmd.h 26.71% <ø> (ø)
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/schema/schema_adapter.cc 42.59% <0.00%> (-0.31%) ⬇️
src/storage/mem_table.cc 89.38% <0.00%> (-0.14%) ⬇️
src/tablet/tablet_impl.cc 61.19% <0.00%> (-0.10%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (+0.01%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964a9b9...b45b64a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

SDK Test Report

  76 files    76 suites   6m 5s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit b45b64a.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Linux Test Report

       54 files       196 suites   53m 24s ⏱️
  9 009 tests   9 005 ✔️ 4 💤 0
13 260 runs  13 256 ✔️ 4 💤 0

Results for commit b45b64a.

@tobegit3hub
Copy link
Collaborator Author

Provide main class to get version from command for openmldb-batch.

@tobegit3hub tobegit3hub merged commit 39ca0db into 4paradigm:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new API for TaskManager to get version
3 participants