Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete functions in src/codec/schema_codec.h #2100

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

KikiDotPy
Copy link
Contributor

Removed

GetSchemaData,
GetCdColumns and
GetSize

functions in src/codec/schema_codec.h as requested in issue #2097

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2100 (b6b7783) into main (964a9b9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2100   +/-   ##
=========================================
  Coverage     75.79%   75.80%           
  Complexity      347      347           
=========================================
  Files           615      615           
  Lines        116921   116921           
  Branches       1015     1015           
=========================================
+ Hits          88623    88631    +8     
+ Misses        28089    28081    -8     
  Partials        209      209           
Impacted Files Coverage Δ
src/codec/schema_codec.h 82.69% <ø> (ø)
src/schema/schema_adapter.cc 42.59% <0.00%> (-0.31%) ⬇️
src/tablet/tablet_impl.cc 61.10% <0.00%> (-0.20%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
src/storage/mem_table.cc 89.38% <0.00%> (-0.14%) ⬇️
src/sdk/sql_cluster_router.cc 55.00% <0.00%> (-0.13%) ⬇️
src/client/tablet_client.cc 55.92% <0.00%> (-0.12%) ⬇️
src/nameserver/name_server_impl.cc 42.80% <0.00%> (+0.13%) ⬆️
src/catalog/tablet_catalog.cc 71.58% <0.00%> (+0.80%) ⬆️
.../query_response_time/deploy_query_response_time.cc 100.00% <0.00%> (+2.89%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964a9b9...b6b7783. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

SDK Test Report

  75 files    75 suites   5m 34s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit b6b7783.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Linux Test Report

       54 files       196 suites   52m 52s ⏱️
  9 009 tests   9 005 ✔️ 4 💤 0
13 260 runs  13 256 ✔️ 4 💤 0

Results for commit b6b7783.

@dl239 dl239 enabled auto-merge (squash) July 6, 2022 12:14
@dl239 dl239 merged commit 0b2b5ed into 4paradigm:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GetSchemaData, GetCdColumns and GetSize functions from codec/schema_codec.h
3 participants