Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update sql_cmd_test.cc #2093

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

Harshvardhantomar
Copy link
Contributor

Removed the unnecessary "DECLARE" from the file.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

Removed the unnecessary "DECLARE" from the file.
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2093 (e7d8486) into main (b455771) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2093      +/-   ##
============================================
- Coverage     75.70%   75.68%   -0.02%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116901              
  Branches       1015     1015              
============================================
- Hits          88499    88481      -18     
- Misses        28193    28211      +18     
  Partials        209      209              
Impacted Files Coverage Δ
src/cmd/sql_cmd_test.cc 99.60% <ø> (ø)
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-1.13%) ⬇️
src/client/tablet_client.cc 55.36% <0.00%> (-0.23%) ⬇️
src/tablet/tablet_impl.cc 60.14% <0.00%> (-0.15%) ⬇️
src/nameserver/name_server_impl.cc 42.80% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b455771...e7d8486. Read the comment docs.

@dl239 dl239 changed the title Update sql_cmd_test.cc refactor: update sql_cmd_test.cc Jul 6, 2022
@dl239 dl239 linked an issue Jul 6, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

SDK Test Report

  75 files    75 suites   5m 38s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit e7d8486.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Linux Test Report

       54 files       196 suites   52m 0s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit e7d8486.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 5fdbe30 into 4paradigm:main Jul 6, 2022
@Harshvardhantomar Harshvardhantomar deleted the patch-1 branch July 6, 2022 07:27
@Harshvardhantomar Harshvardhantomar restored the patch-1 branch July 6, 2022 07:27
@Harshvardhantomar Harshvardhantomar deleted the patch-1 branch July 6, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary DECLARE in cmd/sql_cmd_test.cc
3 participants