Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed unwanted image files #2089

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

ayushshivaji
Copy link
Contributor

  • **Removed the unwanted image files as mentioned by the collaborator.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2089 (d2b446d) into main (a8f8c91) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2089      +/-   ##
============================================
- Coverage     75.72%   75.68%   -0.05%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116901              
  Branches       1015     1015              
============================================
- Hits          88523    88476      -47     
- Misses        28169    28216      +47     
  Partials        209      209              
Impacted Files Coverage Δ
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-3.14%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/catalog/tablet_catalog.cc 69.97% <0.00%> (-0.81%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.32%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/tablet/tablet_impl.cc 60.04% <0.00%> (-0.15%) ⬇️
hybridse/src/vm/runner.cc 67.73% <0.00%> (-0.04%) ⬇️
src/nameserver/name_server_impl.cc 42.79% <0.00%> (-0.03%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f8c91...d2b446d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

SDK Test Report

  75 files    75 suites   6m 46s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit d2b446d.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Linux Test Report

       54 files       196 suites   51m 46s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit d2b446d.

@dl239 dl239 changed the title removed unwanted image files refactor: removed unwanted image files Jul 6, 2022
@dl239 dl239 requested a review from lumianph July 6, 2022 01:32
@dl239 dl239 linked an issue Jul 6, 2022 that may be closed by this pull request
@dl239 dl239 enabled auto-merge (squash) July 6, 2022 02:24
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 4ba3624 into 4paradigm:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused image from images dir
3 participants