feat: support custom order in insert stmt #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sdk
Codecov Report
@@ Coverage Diff @@
## main #2075 +/- ##
============================================
+ Coverage 75.69% 75.80% +0.11%
- Complexity 347 354 +7
============================================
Files 615 616 +1
Lines 116901 117102 +201
Branches 1015 1029 +14
============================================
+ Hits 88484 88766 +282
+ Misses 28208 28125 -83
- Partials 209 211 +2
Continue to review full report at Codecov.
|
vagetablechicken
commented
Jul 7, 2022
java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/common/Pair.java
Show resolved
Hide resolved
aceforeverd
approved these changes
Jul 7, 2022
dl239
reviewed
Jul 7, 2022
dl239
reviewed
Jul 7, 2022
| @@ -48,7 +50,8 @@ public class InsertPreparedStatementImpl implements PreparedStatement { | |||
| private final List<Object> currentDatas; | |||
| private final List<DataType> currentDatasType; | |||
| private final List<Boolean> hasSet; | |||
| private final List<Integer> scehmaIdxs; | |||
| // stmt insert idx -> real table schema idx | |||
| private final List<Pair<Long, Integer>> schemaIdxes; | |||
There was a problem hiding this comment.
the first type of pair is the same as second. set as Integer
There was a problem hiding this comment.
uint32 is long, and idx type of list is int, no the same.
dl239
reviewed
Jul 7, 2022
...penmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/InsertPreparedStatementImpl.java
Outdated
Show resolved
Hide resolved
dl239
reviewed
Jul 7, 2022
...penmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/InsertPreparedStatementImpl.java
Outdated
Show resolved
Hide resolved
…db into sql-insert-row-order
dl239
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2059