Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated test names to UpperCamelCase #2071

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

PrajwalBorkar
Copy link
Contributor

@PrajwalBorkar PrajwalBorkar commented Jul 5, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Changed UnderScoreCase test names to UpperCamelCase.

  • What is the current behavior? (You can also link to an open issue here)
    close ut: avoid using "_" in test name in sdk_catalog_test.cc #2067

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2071 (17bb63a) into main (9950035) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2071   +/-   ##
=========================================
  Coverage     75.70%   75.70%           
  Complexity      347      347           
=========================================
  Files           615      615           
  Lines        116901   116901           
  Branches       1015     1015           
=========================================
+ Hits          88498    88499    +1     
+ Misses        28194    28193    -1     
  Partials        209      209           
Impacted Files Coverage Δ
src/catalog/sdk_catalog_test.cc 100.00% <100.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (-0.78%) ⬇️
src/sdk/db_sdk.cc 67.71% <0.00%> (-0.45%) ⬇️
src/nameserver/name_server_impl.cc 42.65% <0.00%> (-0.10%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.49% <0.00%> (ø)
src/client/tablet_client.cc 55.25% <0.00%> (+0.11%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9950035...17bb63a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

SDK Test Report

  75 files    75 suites   6m 27s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 17bb63a.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Linux Test Report

       54 files       196 suites   51m 47s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 17bb63a.

@dl239 dl239 changed the title Updated test names to UpperCamelCase refactor: updated test names to UpperCamelCase Jul 6, 2022
@dl239 dl239 merged commit a162e2c into 4paradigm:main Jul 6, 2022
@PrajwalBorkar PrajwalBorkar deleted the prajwal-patch1 branch July 6, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ut: avoid using "_" in test name in sdk_catalog_test.cc
3 participants