Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed std::move #2070

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

PrajwalBorkar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Removed std::move from return statement in catalog/sdk_catalog.h

  • What is the current behavior? (You can also link to an open issue here)
    Fixes Remove std::move from return statement in catalog/sdk_catalog.h #2064

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 5, 2022
@dl239 dl239 changed the title Removed std::move refactor: removed std::move Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Linux Test Report

       54 files       196 suites   51m 58s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 893b869.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2070 (893b869) into main (9950035) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2070      +/-   ##
============================================
- Coverage     75.70%   75.68%   -0.02%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116901              
  Branches       1015     1015              
============================================
- Hits          88498    88477      -21     
- Misses        28194    28215      +21     
  Partials        209      209              
Impacted Files Coverage Δ
src/catalog/sdk_catalog.h 48.27% <0.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-4.71%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/nameserver/name_server_impl.cc 42.72% <0.00%> (-0.03%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.49% <0.00%> (ø)
src/tablet/tablet_impl.cc 60.12% <0.00%> (+0.07%) ⬆️
src/sdk/sql_cluster_router.cc 55.04% <0.00%> (+0.12%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9950035...893b869. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

SDK Test Report

  75 files    75 suites   6m 19s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 893b869.

♻️ This comment has been updated with latest results.

@aceforeverd aceforeverd merged commit a8f8c91 into 4paradigm:main Jul 5, 2022
@PrajwalBorkar PrajwalBorkar deleted the prajwal-patch3 branch July 5, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove std::move from return statement in catalog/sdk_catalog.h
3 participants