feat: support exclude current_row
#2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
============================================
+ Coverage 75.67% 75.71% +0.03%
Complexity 347 347
============================================
Files 615 615
Lines 116901 117026 +125
Branches 1015 1025 +10
============================================
+ Hits 88463 88602 +139
+ Misses 28229 28215 -14
Partials 209 209
Continue to review full report at Codecov.
|
aceforeverd
requested review from
vagetablechicken and
zhanghaohit
and removed request for
vagetablechicken
github-actions
bot
added
the
storage-engine
aceforeverd
commented
Jul 4, 2022
when `EXCLUDE CURRENT_ROW` set, only specific window results different execute logic: - ROWS_RANGE window where end frame bound is `0s` or `current row` for others: - ROWS window where end frame bound is `0 or CURRENT ROW`: just same as `0 OPEN PRECEDING` - do not apply to `lag/lead/at` function. - do not matter if window is pure history (window bound already excluded current row) This is a basic support, need more tests
RequestUnionRunner should always include the current row
with combination of: 1. maxsize 2. open preceding bound
sql_node_test & planner_v2_test
- codegen a InnerRowsRangeList for Rows_ragnge exclude current_row window in (batch-)request mode. - redesign the nodes supporting `exclude_current_row`
aceforeverd
force-pushed
the
feat-exclude-current-row-1387
branch
from
68ed6d8 to
c9c7d48
Compare
|
TODO:
|
note interface of `WindowInterface` is changed
zhanghaohit
reviewed
Jul 6, 2022
vagetablechicken
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1387
Here's the overviews
window ( ROWS_RANGE .. [ 0s preceding | current row ] exclude current_row)-> special handlingwindow (ROWS .. [ 0 preceding | current row ] exclude current_row)->window (ROWS .. 0 open preceding)lag over ( .. exclude current_row)-> no effectnew field
exclude_current_row_added to those nodesFrameNode-> set only by physical transformerWindowDefNode-> set by plannerWindowPlanNodePhysicalWindowAggrerationNodePhysicalRequestUnionNodeWindowAggRunnerbatch modeRequestUnionNode(batch-)request modeInnerRowsRangeList-> for (batch-)request mode, construct theInnerRowsRangeList(1, rows_end)forrows_range ( .. os preceding exclude current_row)HistoryWindowtable handler for batch mode.