Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MemTableWindowIterator::Seek has not set record_idx_ properly #2052

Merged
merged 8 commits into from
Aug 2, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 1, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 1, 2022
@dl239 dl239 changed the title fix: fix MemTableWindowIterator::Seek has not set record_idx_ properly fix: MemTableWindowIterator::Seek has not set record_idx_ properly Jul 1, 2022
@dl239 dl239 linked an issue Jul 1, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #2052 (0fe2ac0) into main (6e691e8) will increase coverage by 0.02%.
The diff coverage is 82.03%.

@@             Coverage Diff              @@
##               main    #2052      +/-   ##
============================================
+ Coverage     75.75%   75.78%   +0.02%     
  Complexity      367      367              
============================================
  Files           624      626       +2     
  Lines        118073   118095      +22     
  Branches       1048     1048              
============================================
+ Hits          89446    89496      +50     
+ Misses        28410    28382      -28     
  Partials        217      217              
Impacted Files Coverage Δ
src/storage/mem_table.cc 89.65% <ø> (-0.01%) ⬇️
src/storage/mem_table.h 100.00% <ø> (+3.84%) ⬆️
src/storage/disk_table.cc 81.34% <28.57%> (-1.62%) ⬇️
src/storage/window_iterator.h 66.66% <66.66%> (ø)
src/storage/window_iterator.cc 92.70% <92.70%> (ø)
src/storage/table_iterator_test.cc 100.00% <100.00%> (ø)
src/zk/zk_client.cc 83.37% <0.00%> (-0.26%) ⬇️
src/tablet/tablet_impl.cc 61.58% <0.00%> (-0.05%) ⬇️
hybridse/src/vm/runner.cc 67.74% <0.00%> (-0.04%) ⬇️
src/client/tablet_client.cc 56.15% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e691e8...0fe2ac0. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

SDK Test Report

  77 files    77 suites   8m 2s ⏱️
166 tests 164 ✔️ 2 💤 0
208 runs  206 ✔️ 2 💤 0

Results for commit 0fe2ac0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Linux Test Report

       55 files       200 suites   53m 12s ⏱️
  9 244 tests   9 240 ✔️ 4 💤 0
13 600 runs  13 596 ✔️ 4 💤 0

Results for commit 0fe2ac0.

♻️ This comment has been updated with latest results.

@dl239 dl239 marked this pull request as ready for review July 31, 2022 12:47
@dl239 dl239 merged commit 2dbab30 into 4paradigm:main Aug 2, 2022
@dl239 dl239 deleted the fix/mem_window_iterator branch August 2, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemTableWindowIterator::Seek will not set record_idx_ properly
3 participants