Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deleted enable_show_tp from flags.cc #2051

Merged
merged 14 commits into from
Jul 1, 2022
Merged

Conversation

frazie
Copy link
Contributor

@frazie frazie commented Jun 30, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix Delete enable_show_tp from flags.cc #1980

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #2051 (c02a171) into main (094a424) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2051      +/-   ##
============================================
- Coverage     75.70%   75.69%   -0.02%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116903   116903              
  Branches       1015     1015              
============================================
- Hits          88499    88484      -15     
- Misses        28195    28210      +15     
  Partials        209      209              
Impacted Files Coverage Δ
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.32%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/client/ns_client.cc 46.80% <0.00%> (-0.15%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094a424...c02a171. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   5m 26s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit c02a171.

@github-actions
Copy link
Contributor

Linux Test Report

       54 files       196 suites   51m 56s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit c02a171.

@dl239 dl239 changed the title Deleted enable_show_tp from flags.cc refactor: deleted enable_show_tp from flags.cc Jul 1, 2022
@dl239 dl239 enabled auto-merge (squash) July 1, 2022 03:02
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit eac24df into 4paradigm:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete enable_show_tp from flags.cc
3 participants