Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MakeResultSet using wrong schema in projection #2049

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 30, 2022

The result returned by Scan function in TableReader is incorrect currently.

@dl239 dl239 changed the title fix: MakeResultSet using wrong schema in projection fix: MakeResultSet using wrong schema in projection Jun 30, 2022
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 30, 2022
@dl239 dl239 linked an issue Jun 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #2049 (5677418) into main (38b1e9b) will increase coverage by 0.12%.
The diff coverage is 76.08%.

@@             Coverage Diff              @@
##               main    #2049      +/-   ##
============================================
+ Coverage     75.66%   75.79%   +0.12%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116794   116923     +129     
  Branches       1015     1015              
============================================
+ Hits          88378    88626     +248     
+ Misses        28207    28088     -119     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/result_set_sql.cc 72.00% <35.29%> (+19.61%) ⬆️
src/cmd/sql_cmd_test.cc 99.61% <100.00%> (+<0.01%) ⬆️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 70.77% <0.00%> (-0.81%) ⬇️
src/sdk/db_sdk.cc 66.59% <0.00%> (-0.68%) ⬇️
src/nameserver/name_server_impl.cc 42.68% <0.00%> (-0.14%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b1e9b...5677418. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   7m 22s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 5677418.

@github-actions
Copy link
Contributor

Linux Test Report

       54 files       196 suites   50m 9s ⏱️
  9 009 tests   9 005 ✔️ 4 💤 0
13 260 runs  13 256 ✔️ 4 💤 0

Results for commit 5677418.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit afff40e into 4paradigm:main Jul 6, 2022
@dl239 dl239 deleted the fix/result_set branch July 6, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MakeResultSet using wrong schema in projection
3 participants