fix: use int to record string length instead of map #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mango <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2044 +/- ##
============================================
+ Coverage 75.66% 75.71% +0.04%
Complexity 347 347
============================================
Files 615 615
Lines 116794 116901 +107
Branches 1015 1015
============================================
+ Hits 88378 88513 +135
+ Misses 28207 28179 -28
Partials 209 209
Continue to review full report at Codecov.
|
Signed-off-by: mango <[email protected]>
| @@ -367,9 +367,7 @@ public void testInsertPreparedState(SqlExecutor router) { | |||
| insert = "insert into tsql1010 values(?, ?, ?, ?, ?);"; | |||
| PreparedStatement impl3 = router.getInsertPreparedStmt(dbname, insert); | |||
| impl3.setLong(1, 1003); | |||
| impl3.setString(3, "zhejiangxx"); | |||
There was a problem hiding this comment.
Mind that do not delete these lines
There was a problem hiding this comment.
Got, I think use List or Map more better instead of int, because we want to implement multiple set and save the last value. So this issue and PR may unnecessary
There was a problem hiding this comment.
Done, reverted
Signed-off-by: mango <[email protected]>
dl239
approved these changes
Jun 30, 2022
Signed-off-by: mango <[email protected]>
aceforeverd
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mango [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Fixed Use int value to record string length instead of Map in
InsertPreparedStatementImpl#1979What is the new behavior (if this is a feature change)?
None